linux-kernel - Re: [patch 0/2] [V4] block: Support online resize of disk partitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Jul 2012 10:20:01 -0400
From:	Vivek Goyal <vgoyal@...hat.com>
To:	Phillip Susi <psusi@...ntu.com>
Cc:	linux-kernel@...r.kernel.org, axboe@...nel.dk, dm-devel@...hat.com,
	kzak@...hat.com, maxim.patlasov@...il.com
Subject: Re: [patch 0/2] [V4] block: Support online resize of disk partitions

On Tue, Jul 10, 2012 at 10:13:19AM -0400, Phillip Susi wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> On 7/10/2012 9:57 AM, Vivek Goyal wrote:
> > +static inline sector_t part_nr_sects_read(struct hd_struct *part) 
> > +{ +#if BITS_PER_LONG==32 && defined(CONFIG_LBDAF) &&
> > defined(CONFIG_SMP) +	sector_t nr_sects; +	unsigned seq; +	do { +
> > seq = read_seqcount_begin(&part->nr_sects_seq); +		nr_sects =
> > part->nr_sects; +	} while (read_seqcount_retry(&part->nr_sects_seq,
> > seq)); +	return nr_sects; +#elif BITS_PER_LONG==32 &&
> > defined(CONFIG_PREEMPT)
> 
> Shouldn't this be BITS_PER_LONG==32 && defined(CONFIG_LBDAF) &&
> defined(CONFIG_PREEMPT)?  No sense disabling preemption when the
> sector size is also 32 bits.

Yes. Good catch. We don't want to disable/enable preemption for 32bit UP 
kernels with sector size 32bit. I will modify the patch and repost soon.

BTW, what happened to all the new lines in the code above. Looks like you
mailer chewed these up.

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/