linux-kernel - [PATCH v2 0/2] fat (exportfs): fix dentry reconnection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 10 Jul 2012 09:20:51 -0500
From:	"Steven J. Magnani" <steve@...idescorp.com>
To:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
Cc:	linux-kernel@...r.kernel.org, steve@...idescorp.com
Subject: [PATCH v2 0/2] fat (exportfs): fix dentry reconnection

Under memory pressure, the system may evict dentries from cache.
When the FAT driver receives a NFS request involving an evicted dentry,
it is unable to reconnect it to the filesystem root. 
This causes the request to fail, often with ENOENT.

This is partially due to ineffectiveness of the current FAT NFS implementation,
and partially due to an unimplemented fh_to_parent method. The latter
can cause file accesses to fail on shares exported with subtree_check.

This patch set provides the FAT driver with the ability to reconnect dentries.
NFS file handle generation and lookups are simplified and made congruent with
ext2.

Testing has involved a memory-starved virtual machine running 3.5-rc5
that exports a ~2 GB vfat filesystem containing a kernel tree
(~770 MB, ~40000 files, 9 levels). Both 'cp -r' and 'ls -lR' operations
were performed from a client, some overlapping, some consecutive.
Exports with 'subtree_check' and 'no_subtree_check' have been tested.

Note that while this patch set improves FAT's NFS support, it does not
eliminate ESTALE errors completely.

The following should be considered for NFS clients who are sensitive to ESTALE:

* Mounting with lookupcache=none
  Unfortunately this can degrade performance severely, particularly for deep
  filesystems.

* Incorporating VFS patches to retry ESTALE failures on the client-side, 
  such as https://lkml.org/lkml/2012/6/29/381

* Handling ESTALE errors in client application code

This series depends on the following patches:
* fat: Fix non-atomic NFS i_pos read
* fat: Accessors for msdos_dir_entry 'start' fields
* fat: Refactor shortname parsing

Changes since v1:
* Dropped code to reconstitute evicted inodes. Too risky.
* Dropped FAT-specific get_name method. Not needed.
* Added index of directories by i_logstart (per. H. OGAWA)
  and "nfs" mount option to enable it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/