linux-kernel - Re: [PATCH v3 1/8] bluetooth: /proc/net/ entries for bluetooth protocols

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Jul 2012 10:42:02 +0300
From:	Andrei Emeltchenko <andrei.emeltchenko.news@...il.com>
To:	Masatake YAMATO <yamato@...hat.com>
Cc:	linux-kernel@...r.kernel.org, linux-bluetooth@...r.kernel.org
Subject: Re: [PATCH v3 1/8] bluetooth: /proc/net/ entries for bluetooth
 protocols

Hi Masatake,

On Wed, Jul 11, 2012 at 09:19:06PM +0900, Masatake YAMATO wrote:
> > I've tested the patch and it creates entries in /proc/net
> 
> Thanks.
>  
> > BTW: Shall lsof be able to identify l2cap protocol?
> > 
> > for l2test it prints: "can't identify protocol"
> 
> No. I'll work on lsof side after the kernel side
> patches are merged to the main line.

OK, patch looks good though I would eliminate 2 new sparse warnings with
__acquires and __releases attributes.

net/bluetooth/af_bluetooth.c:540:13: warning: context imbalance in
'bt_seq_start' - wrong count at exit
net/bluetooth/af_bluetooth.c:557:13: warning: context imbalance in
'bt_seq_stop' - unexpected unlock

Best regards 
Andrei Emeltchenko

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/