linux-kernel - Re: [trivial PATCH 2/7] ixgbe: remove unused #define

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Jul 2012 11:15:38 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Jon Mason <jdmason@...zu.us>
Cc:	trivial@...nel.org, linux-kernel@...r.kernel.org,
	Jesse Brandeburg <jesse.brandeburg@...el.com>,
	Bruce Allan <bruce.w.allan@...el.com>,
	Carolyn Wyborny <carolyn.wyborny@...el.com>,
	Don Skidmore <donald.c.skidmore@...el.com>,
	Greg Rose <gregory.v.rose@...el.com>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>,
	Alex Duyck <alexander.h.duyck@...el.com>,
	John Ronciak <john.ronciak@...el.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [trivial PATCH 2/7] ixgbe: remove unused #define

On Tue, 2012-07-10 at 15:43 -0700, Jeff Kirsher wrote:
> On Tue, 2012-07-10 at 15:31 -0700, Jon Mason wrote:
> > Remove unused IXGBE_INTEL_VENDOR_ID #define
> > 
> > Signed-off-by: Jon Mason <jdmason@...zu.us>
> > Cc: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> > Cc: Jesse Brandeburg <jesse.brandeburg@...el.com>
> > Cc: Bruce Allan <bruce.w.allan@...el.com>
> > Cc: Carolyn Wyborny <carolyn.wyborny@...el.com>
> > Cc: Don Skidmore <donald.c.skidmore@...el.com>
> > Cc: Greg Rose <gregory.v.rose@...el.com>
> > Cc: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
> > Cc: Alex Duyck <alexander.h.duyck@...el.com>
> > Cc: John Ronciak <john.ronciak@...el.com>
> > ---
> >  drivers/net/ethernet/intel/ixgbe/ixgbe_type.h |    3 ---
> >  1 file changed, 3 deletions(-)
> 
> This should also go through David Miller's networking tree's.  Adding
> netdev mailing list.
> 
> Acked-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

After looking at this further, I rescind my ACK.

NAK, this define is used in several places in ixgbe_main.c and the
driver will not compile with this patch.

> 
> > 
> > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h b/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h
> > index 204848d..c8d8040 100644
> > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h
> > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_type.h
> > @@ -32,9 +32,6 @@
> >  #include <linux/mdio.h>
> >  #include <linux/netdevice.h>
> >  
> > -/* Vendor ID */
> > -#define IXGBE_INTEL_VENDOR_ID   0x8086
> > -
> >  /* Device IDs */
> >  #define IXGBE_DEV_ID_82598               0x10B6
> >  #define IXGBE_DEV_ID_82598_BX            0x1508
> 
> 


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)