linux-kernel - Re: [PATCH 2/2] cgroup: fix cgroup hierarchy umount race

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 14 Jul 2012 13:08:52 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	'Tejun Heo' <tj@...nel.org>
Cc:	Shyju PV <shyju.pv@...wei.com>, 'Li Zefan' <lizefan@...wei.com>,
	'Sanil kumar' <sanil.kumar@...wei.com>,
	'Masanari Iida' <standby24x7@...il.com>,
	'LKML' <linux-kernel@...r.kernel.org>,
	'Cgroups' <cgroups@...r.kernel.org>, levinsasha928@...il.com,
	nagamani.mantha@...wei.com
Subject: Re: [PATCH 2/2] cgroup: fix cgroup hierarchy umount race

On Sat, Jul 07, 2012 at 04:46:59PM -0700, 'Tejun Heo' wrote:
> Fix it by holding an extra superblock->s_active reference across
> dput() from css release, which is the dput() path added by 48ddbe1946
> and the only one which doesn't hold an extra s_active ref across the
> final cgroup dput().

> @@ -3883,8 +3883,12 @@ static void css_dput_fn(struct work_struct *work)
>  {
>  	struct cgroup_subsys_state *css =
>  		container_of(work, struct cgroup_subsys_state, dput_work);
> +	struct dentry *dentry = css->cgroup->dentry;
> +	struct super_block *sb = dentry->d_sb;
>  
> -	dput(css->cgroup->dentry);
> +	atomic_inc(&sb->s_active);
> +	dput(dentry);
> +	deactivate_super(sb);
>  }

While we are at it, what guarantees that css->dput_work will complete before
css->cgroup or the object containing css get freed under us?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/