linux-kernel - Re: Small bug: Wrong return check from idr_pre

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 15 Jul 2012 01:23:17 +0200 (CEST)
From:	Jesper Juhl <jj@...osbits.net>
To:	Silva Paulo <psdasilva@...oo.com>
cc:	"torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: Small bug: Wrong return check from idr_pre_get in loop.c

On Fri, 13 Jul 2012, Silva Paulo wrote:

> idr_pre_get never returns a value < 0. It returns 0 (no memory) or 1 (OK).
> 
Please read Documentation/SubmittingPatches

In summary:
 - you are missing a Signed-off-by: line.
 - there is no diffstat.
 - the patch is an attachment, not inline in the email.
 - the recipients list of the email could be improved (see below).

If you had used scripts/get_maintainer.pl on your patch you'd have gotten 
a better list of recipients for your patch mail:
  $ scripts/get_maintainer.pl My_linux-3.5-rc6_patches
  Jens Axboe <axboe@...nel.dk> (commit_signer:15/17=88%)
  Andrew Morton <akpm@...ux-foundation.org> (commit_signer:6/17=35%)
  Kay Sievers <kay.sievers@...y.org> (commit_signer:5/17=29%)
  Jeff Moyer <jmoyer@...hat.com> (commit_signer:2/17=12%)
  Dmitry Monakhov <dmonakhov@...nvz.org> (commit_signer:2/17=12%)
  linux-kernel@...r.kernel.org (open list)

Please try again.

-- 
Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/