linux-kernel - [PATCH] lib/kobject: restore old name on rename failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 16 Jul 2012 21:37:10 +0800
From:	Dong Hao <haodong@...ux.vnet.ibm.com>
To:	linux-kernel@...r.kernel.org
Cc:	gregkh@...uxfoundation.org, shangw@...ux.vnet.ibm.com,
	Dong Hao <haodong@...ux.vnet.ibm.com>
Subject: [PATCH] lib/kobject: restore old name on rename failure

From: Dong Hao <haodong@...ux.vnet.ibm.com>

The patch restores the old name while we fail to set the new
name for the kobject.

Signed-off-by: Dong Hao <haodong@...ux.vnet.ibm.com>
---
 lib/kobject.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/lib/kobject.c b/lib/kobject.c
index ef3d807..9d396c5 100644
--- a/lib/kobject.c
+++ b/lib/kobject.c
@@ -222,8 +222,10 @@ int kobject_set_name_vargs(struct kobject *kobj, const char *fmt,
 		return 0;
 
 	kobj->name = kvasprintf(GFP_KERNEL, fmt, vargs);
-	if (!kobj->name)
+	if (!kobj->name){
+		kobj->name = old_name;
 		return -ENOMEM;
+	}
 
 	/* ewww... some of these buggers have '/' in the name ... */
 	while ((s = strchr(kobj->name, '/')))
-- 
1.7.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/