lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 Jul 2012 09:56:23 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Grant Likely <grant.likely@...retlab.ca> Cc: Rob Herring <rob.herring@...xeda.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Lars-Peter Clausen <lars@...afoo.de>, linux-kernel@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org, kernel-janitors@...r.kernel.org Subject: [patch] driver-core: dev_to_node() should handle NULL pointers What prompted this patch is that in dma_pool_create() we call dev_to_node() before checking whether "dev" is NULL. It looks like there are places which call dma_pool_create() with a NULL pointer. An example is in drivers/usb/gadget/amd5536udc.c. Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com> --- Static checker fix. diff --git a/include/linux/device.h b/include/linux/device.h index aa7b3b4..c80e7a8d 100644 --- a/include/linux/device.h +++ b/include/linux/device.h @@ -714,7 +714,9 @@ int dev_set_name(struct device *dev, const char *name, ...); #ifdef CONFIG_NUMA static inline int dev_to_node(struct device *dev) { - return dev->numa_node; + if (dev) + return dev->numa_node; + return -1; } static inline void set_dev_node(struct device *dev, int node) { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists