linux-kernel - Re: [PATCH NEXT]staging "tidspbridge" Fix typos.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 Jul 2012 20:37:50 -0700
From:	"Justin P. Mattock" <justinmattock@...il.com>
To:	"Ramirez Luna, Omar" <omar.ramirez@...com>
CC:	gregkh@...uxfoundation.org, vjaquez@...lia.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH NEXT]staging "tidspbridge" Fix typos.

On 07/23/2012 01:44 PM, Ramirez Luna, Omar wrote:
> Hi Justin,
>
> On Mon, Jul 23, 2012 at 8:49 AM, Justin P. Mattock
> <justinmattock@...il.com> wrote:
>> diff --git a/drivers/staging/tidspbridge/core/tiomap3430.c b/drivers/staging/tidspbridge/core/tiomap3430.c
>> index f9609ce..2c82d5a 100644
>> --- a/drivers/staging/tidspbridge/core/tiomap3430.c
>> +++ b/drivers/staging/tidspbridge/core/tiomap3430.c
>> @@ -328,7 +328,7 @@ static int bridge_brd_read(struct bridge_dev_context *dev_ctxt,
>>                                             ul_num_bytes, mem_type);
>>                  return status;
>>          }
>> -       /* copy the data from  DSP memory, */
>> +       /* copy the data from DSP memory, */
>
> I guess we can get rid of the comma (,) at the end of this sentence.

good catch!

>
> ...
>> diff --git a/drivers/staging/tidspbridge/include/dspbridge/proc.h b/drivers/staging/tidspbridge/include/dspbridge/proc.h
>> index a82380e..9cd5022 100644
>> --- a/drivers/staging/tidspbridge/include/dspbridge/proc.h
>> +++ b/drivers/staging/tidspbridge/include/dspbridge/proc.h
>> @@ -263,7 +263,7 @@ extern int proc_get_processor_id(void *proc, u32 * proc_id);
>>    *  Returns:
>>    *      0     :   Success.
>>    *      -EFAULT :   Invalid processor handle.
>> - *      -EPERM   :   General failure while retireving processor trace
>> + *      -EPERM   :   General failure while retireing processor trace
>
> This was meant to be 'retrieving'.
>
> And given that this is focused on tidspbridge, could you change the
> patch subject? To: staging: tidspbridge: fix typos.
>
> Cheers,
>
> Omar
>

ah.. I see now.. comments can be tough to decipher sometimes with what 
the writer is saying, helps to know what the code is doing.

cheers, resending the revised version, and Thank you for taking the time.

Justin P. Mattock
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/