linux-kernel - Re: [PATCH] staging: bcm: use SEEK_SET instead of 0 in vfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 24 Jul 2012 21:23:13 -0400
From:	Kevin McKinney <klmckinney1@...il.com>
To:	Vivek Trivedi <vtrivedi018@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Dan Carpenter <dan.carpenter@...cle.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: bcm: use SEEK_SET instead of 0 in vfs_llseek

On Tue, Jul 24, 2012 at 09:25:04PM +0530, Vivek Trivedi wrote:
> They're equivalent, but SEEK_SET seems more informative...
> 
> Signed-off-by: Vivek Trivedi <vtrivedi018@...il.com>
> Signed-off-by: Namjae Jeon <linkinjeon@...il.com>
> ---
>  drivers/staging/bcm/Misc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/bcm/Misc.c b/drivers/staging/bcm/Misc.c
> index 8223a69..8fab3ec 100644
> --- a/drivers/staging/bcm/Misc.c
> +++ b/drivers/staging/bcm/Misc.c
> @@ -203,7 +203,7 @@ static int BcmFileDownload(PMINI_ADAPTER Adapter, const char *path, unsigned int
>  	}
>  	oldfs = get_fs();
>  	set_fs(get_ds());
> -	vfs_llseek(flp, 0, 0);
> +	vfs_llseek(flp, 0, SEEK_SET);

Acked-by: Kevin McKinney <klmckinney1@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/