linux-kernel - Re: [PATCH 13/18] ARM: ux500: Add ux500 PCM to DB8500 Device Tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Jul 2012 15:26:58 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	STEricsson_nomadik_linux@...t.st.com, linus.walleij@...ricsson.com,
	arnd@...db.de, olalilja@...oo.se, ola.o.lilja@...ricsson.com,
	alsa-devel@...a-project.org, lrg@...com
Subject: Re: [PATCH 13/18] ARM: ux500: Add ux500 PCM to DB8500 Device Tree

On 30/07/12 14:40, Mark Brown wrote:
> On Mon, Jul 30, 2012 at 08:32:43AM +0100, Lee Jones wrote:
>> On 29/07/12 21:50, Mark Brown wrote:
>>> On Fri, Jul 27, 2012 at 01:45:57PM +0100, Lee Jones wrote:
>
>>>> +		pcm: ux500-pcm {
>>>> +			compatible = "stericsson,ux500-pcm";
>>>> +		};
>>>> +
>
>>> One of two things is wrong here.  Either you've not provided any
>>> information about the hardware so the driver won't be able to work out
>>> what to talk to or you've not provided any data so you're registering a
>>> purely virtual Linux-internal device via the device tree.
>
>>> Once more, the idea here is to describe the hardware not to dump Linux's
>>> internal data structures into the device tree.
>
>> We use it register the driver for probe()ing. In the same way we do
>> for the PMU and Regulators. All three of which actually belong to a
>> different hardware block. Do you know of a better way to register
>> those devices?
>
> You've not identified which of the two cases above we're in...  assuming
> it's a virtal device look at how the DT bindings for the other platforms
> are doing things.

I thought it would have been obvious by my response. The PMU seems to be 
a virtual device with no registers or IRQs.

I've found a DT which seems to do it in the same way as I do 
'arch/powerpc/boot/dts/p1022ds.dts', but some others call PCM 
registration from the CPU-side DAI probe(). Would that be your preference?

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/