linux-kernel - Re: [PATCH][TRIVIAL] mm/frontswap: fix uninit'ed variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 31 Jul 2012 11:23:32 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Seth Jennings <sjenning@...ux.vnet.ibm.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	trivial@...nel.org
Subject: Re: [PATCH][TRIVIAL] mm/frontswap: fix uninit'ed variable warning

On Mon, Jul 30, 2012 at 02:47:44PM -0500, Seth Jennings wrote:
> Fixes uninitialized variable warning on 'type' in frontswap_shrink().
> type is set before use by __frontswap_unuse_pages() called by
> __frontswap_shrink() called by frontswap_shrink() before use by
> try_to_unuse().

OK, applied.
> 
> Signed-off-by: Seth Jennings <sjenning@...ux.vnet.ibm.com>
> ---
> Based on next-20120730
> 
>  mm/frontswap.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/frontswap.c b/mm/frontswap.c
> index 6b3e71a..89dc399 100644
> --- a/mm/frontswap.c
> +++ b/mm/frontswap.c
> @@ -292,7 +292,7 @@ static int __frontswap_shrink(unsigned long target_pages,
>  void frontswap_shrink(unsigned long target_pages)
>  {
>  	unsigned long pages_to_unuse = 0;
> -	int type, ret;
> +	int uninitialized_var(type), ret;
>  
>  	/*
>  	 * we don't want to hold swap_lock while doing a very
> -- 
> 1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/