| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 31 Jul 2012 18:01:49 +0200 From: Damien Cassou <damien.cassou@...il.com> To: Sachin Kamat <sachin.kamat@...aro.org> Cc: Florian Tobias Schandinat <FlorianSchandinat@....de>, kernel-janitors@...r.kernel.org, linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 4/5] drivers/video/da8xx-fb.c: use devm_ functions The whole patch is incorrect because of: On Tue, Jul 31, 2012 at 5:47 PM, Sachin Kamat <sachin.kamat@...aro.org> wrote: >> - ret = request_irq(par->irq, lcdc_irq_handler, 0, >> - DRIVER_NAME, par); >> + ret = devm_request_irq(&device->dev, par->irq, lcdc_irq_handler, 0, >> + DRIVER_NAME, par); The following message explains why this is problematic: http://marc.info/?l=kernel-janitors&m=134374464625591&w=2 Please ignore this whole patch altogether. Sorry about that. -- Damien Cassou http://damiencassou.seasidehosting.st "Lambdas are relegated to relative obscurity until Java makes them popular by not having them." James Iry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists