linux-kernel - RE: [PATCH] gpio: samsung: Fix off-by-one bug in gpio addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 01 Aug 2012 08:27:45 +0900
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	'Linus Walleij' <linus.walleij@...aro.org>,
	'Sean Paul' <seanpaul@...omium.org>,
	'Sangsu Park' <sangsu4u.park@...sung.com>
Cc:	grant.likely@...retlab.ca, linus.walleij@...ricsson.com,
	linux-kernel@...r.kernel.org, olofj@...omium.org,
	dianders@...omium.org
Subject: RE: [PATCH] gpio: samsung: Fix off-by-one bug in gpio addresses

Linus Walleij wrote:
> 
> On Fri, Jul 20, 2012 at 10:58 PM, Sean Paul <seanpaul@...omium.org> wrote:
> 
> > Move gpc4 to the end of the automatically processed gpio controllers so
> > we don't taint the automatic offset calculation.
> >
> > This bug caused all controllers coming after gpc4 to map to the
> > incorrect address. The result is <&gpd1 0 0 0 0> would actually map to
> > GPIO 0 in gpd0.
> >
> > Signed-off-by: Sean Paul <seanpaul@...omium.org>
> 
> Samsung people, please comment on this patch.
> 
Looks good to me, please keep going on.
And feel free to add my ack on this.

Acked-by: Kukjin Kim <kgene.kim@...sung.com>

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@...sung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/