linux-kernel - [PATCH 0/3] Use get_online_cpus to avoid races involving for_each_online

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 2 Aug 2012 17:03:45 -0700
From:	Silas Boyd-Wickizer <sbw@....edu>
To:	linux-kernel@...r.kernel.org
Cc:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Subject: [PATCH 0/3] Use get_online_cpus to avoid races involving
 for_each_online_cpu

Hello,

I've found 4 races involving for_each_online_cpu that could have ill
effects.  All 4 occur in code that can be compiled as modules, but
which is probably usually linked statically.  All 4 occur during
module init and/or exit.  I've written patches for 3 of the 4, and
will describe the 4th race in separate e-mail.

I've been checking the usages of for_each_online_cpu for the
possibility of races with offlining and onlining CPUs.  I used
libsparse and kernel source annotations to check that code uses
for_each_online_cpu in contexts with hotplug disabled
(e.g. get_online_cpus(), preempt_disable, ..).  I compiled with an
x86 64-bit allyesconfig and weeded out false positives (e.g. careful
use of CPU notifiers) by hand.

I've identified about 40 races, but only 4 that seem to have
unintentional and potentially harmful effects.

Here is a link to my checker code, which isn't fit for inclusion in
anything:

  http://pdos.csail.mit.edu/~sbw/online-checker/

Silas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/