linux-kernel - Re: [PATCH v2 0/2] I2C: SIS964: Bus driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 3 Aug 2012 18:07:12 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Amaury Decrême <amaury.decreme@...il.com>
Cc:	ben-linux@...ff.org, w.sang@...gutronix.de, rob@...dley.net,
	jeffrey.t.kirsher@...el.com, akpm@...ux-foundation.org,
	davem@...emloft.net, gregkh@...uxfoundation.org, joe@...ches.com,
	ralf@...ux-mips.org, dirk.brandewie@...il.com,
	jayachandranc@...logicmicro.com, linux-i2c@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] I2C: SIS964: Bus driver

Hi Amaury,

On Fri,  3 Aug 2012 17:35:43 +0200, Amaury Decrême wrote:
> This series of patches are a I2C bus driver for the SIS964.
> 
> 
> The SIS964 is nearly the same as SIS630 for the SMBUS :
> 	- Most of the SMBus registers (Status, Enable, Control,
> 	  Host Control, etc.) are at the same adresses + 0x60
> 	- The register count is 21 instead of 20
> 
> The SIS964 name is ambiguous as this chip isn't part of the SIS96X
> family and behaves differently.
> 
> The datasheets have been used to develop the driver based on the
> exsiting driver for I2C SIS630 . 

What is the rationale for not adding support for the new chip to
i2c-sis630 then? That would probably be a lot easier to review.

> Content of the patches:
> 	- 1/2 The driver itself
> 	- 2/2 Documentation, Kconfig, Makefile, Maintainers

This split makes little sense. Integration should come with the driver,
otherwise even build-testing is impossible.


-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/