linux-kernel - Re: [PATCH]: With no attatchment NOT SPAM, a REWRITE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 6 Aug 2012 11:52:36 +1000
From:	Julian Calaby <julian.calaby@...il.com>
To:	Christopher Sacchi <chris.sacchi@...il.com>
Cc:	linux-wireless@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH]: With no attatchment NOT SPAM, a REWRITE

Hi Christopher,

On Mon, Aug 6, 2012 at 11:01 AM, Christopher Sacchi
<chris.sacchi@...il.com> wrote:
> Hey guys, this should work now.

I see the changes you made, however you're not going to get them
accepted in this format.

See Documentation/SubmittingPatches

Online here: https://git.kernel.org/?p=linux/kernel/git/linville/wireless-testing.git;a=blob;f=Documentation/SubmittingPatches;h=c379a2a6949f1c1cac04fb6f185c633512f37061;hb=HEAD



> --
> --- main.c      2012-07-21 20:58:29.000000000 +0000
> +++ mainnew.c   2012-08-05 20:00:37.000000000 +0000
> @@ -32,7 +32,7 @@
>  #include "led.h"
>  #include "cfg.h"
>  #include "debugfs.h"
> -

Why are you removing the blank line - it's required as part of the
kernel coding style.

> +#include "net/rfkill/rfkill.h"

You don't seem to actually be adding any code that uses anything in
this header and don't explain why it's needed.

>  static struct lock_class_key ieee80211_rx_skb_queue_class;
>
>  void ieee80211_configure_filter(struct ieee80211_local *local)
> @@ -183,6 +183,7 @@
>                  *
>                  */
>                 /* WARN_ON(ret); */
> +               WARN_ON(1)

What bug is this fixing? What problem is this solving?

Thanks,

-- 
Julian Calaby

Email: julian.calaby@...il.com
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/