lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 6 Aug 2012 20:34:13 -0700 From: Greg KH <gregkh@...uxfoundation.org> To: Bryan Wu <bryan.wu@...onical.com> Cc: Colin Cross <ccross@...roid.com>, linux-kernel@...r.kernel.org, Henrique de Moraes Holschuh <hmh@....eng.br>, Richard Purdie <rpurdie@...ys.net>, linux-leds@...r.kernel.org Subject: Re: [PATCH] leds: triggers: send uevent when changing triggers On Tue, Aug 07, 2012 at 10:57:29AM +0800, Bryan Wu wrote: > On Wed, Aug 1, 2012 at 2:28 AM, Colin Cross <ccross@...roid.com> wrote: > > On Thu, Jul 26, 2012 at 9:04 PM, Bryan Wu <bryan.wu@...onical.com> wrote: > >> On Fri, Jul 27, 2012 at 12:51 AM, Greg KH <gregkh@...uxfoundation.org> wrote: > >>> On Thu, Jul 26, 2012 at 01:03:11PM +0800, Bryan Wu wrote: > >>>> Just one quick patch for my idea: emitting a uevent in sysfs_create_file(). > >>>> > >>>> -- > >>>> diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c > >>>> index 00012e3..04da869 100644 > >>>> --- a/fs/sysfs/file.c > >>>> +++ b/fs/sysfs/file.c > >>>> @@ -570,10 +570,14 @@ int sysfs_add_file(struct sysfs_dirent *dir_sd, > >>>> const struct attribute *attr, > >>>> > >>>> int sysfs_create_file(struct kobject * kobj, const struct attribute * attr) > >>>> { > >>>> + int err = 0; > >>>> + > >>>> BUG_ON(!kobj || !kobj->sd || !attr); > >>>> > >>>> - return sysfs_add_file(kobj->sd, attr, SYSFS_KOBJ_ATTR); > >>>> + err = sysfs_add_file(kobj->sd, attr, SYSFS_KOBJ_ATTR); > >>>> + kobject_uevent(kobj, KOBJ_CHANGE); > >>> > >>> That's a veritable flood of change events when a new kobject is created, > >>> right? It also created uevents for a device that has not told userspace > >>> that it is even present, which could cause massive confusion, don't you > >>> think? > >>> > >> > >> Indeed, this is unacceptable. I reworked a new patchset and just sent > >> our for you review. > >> > >> Thanks, > >> -Bryan > > > > Given the rejection of the other solutions to this problem, and chance > > of getting this acked? > > Greg, Richard and Henrique, can I take you guys' Ack here? Ack for what specific patch are you referring to? greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists