linux-kernel - RE: [PATCH v2] usb:musb:musb_host: Handle highmem in PIO mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 8 Aug 2012 08:40:04 +0200
From:	Virupax SADASHIVPETIMATH <virupax.sadashivpetimath@...ricsson.com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	"balbi@...com" <balbi@...com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	Praveena NADAHALLY <praveen.nadahally@...ricsson.com>,
	Rajaram REGUPATHY <ragupathy.rajaram@...ricsson.com>,
	Vikrant BAPAT <vikrant.bapat@...ricsson.com>
Subject: RE: [PATCH v2] usb:musb:musb_host: Handle highmem in PIO mode



> -----Original Message-----
> From: Alan Stern [mailto:stern@...land.harvard.edu]
> Sent: Tuesday, August 07, 2012 11:17 PM
> To: Virupax SADASHIVPETIMATH
> Cc: balbi@...com; gregkh@...uxfoundation.org; linux-usb@...r.kernel.org; linux-
> kernel@...r.kernel.org; linus.walleij@...aro.org; Praveena NADAHALLY; Rajaram
> REGUPATHY; Vikrant BAPAT
> Subject: Re: [PATCH v2] usb:musb:musb_host: Handle highmem in PIO mode
> 
> 
> > +	 */
> > +	if (!urb->transfer_buffer)
> > +		use_sg = true;
> 
> Here you test urb->transfer_buffer.

I will make the test as 
	if (!use_sg && !urb->transfer_buffer)
		use_sg = true;

> > +	if (use_sg) {
> > +		/* sg_miter_start is already done in musb_ep_program */
> > +		if (!sg_miter_next(&qh->sg_miter)) {
> > +			dev_err(musb->controller, "error: sg list empty\n");
> > +			sg_miter_stop(&qh->sg_miter);
> > +			status = -EINVAL;
> > +			goto done;
> > +		}
> > +		urb->transfer_buffer = qh->sg_miter.addr;
> 
> And here you set it.  As a result, on the next iteration of this
> routine the test above won't work right.  (This function gets invoked
> once for each entry in the sg list, right?)
> 
> Is there any reason to set urb->transfer_buffer here?  You could just
> use qh->sg_miter.addr directly in the musb_write_fifo() call two lines
> below.

I will change it. 

Thanks 
Virupax S 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/