[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 8 Aug 2012 14:17:14 +0100
From: Mark Brown <broonie@...nsource.wolfsonmicro.com>
To: Lee Jones <lee.jones@...aro.org>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>,
linus.walleij@...ricsson.com, arnd@...db.de,
linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
STEricsson_nomadik_linux@...t.st.com,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/1] Input: ab8500-ponkey: Make the distinction between
DT and non-DT boots
On Wed, Aug 08, 2012 at 12:40:38PM +0100, Lee Jones wrote:
> On Wed, Aug 08, 2012 at 10:49:52AM +0100, Mark Brown wrote:
> > > - MFD adds the IRQ base to the hwirq and registers it as a virq
> > Just don't do this step - the only reason to do it is for mapping back
> > into a linear domain but if you're going to do this...
> > > - AB8500 child devices use *_get_virq() to convert virq to virq - *ERROR*
> > ...then it's redundant. The mapping functions in the domain code
> > replace this functionality.
> No, the other way round. This is now required all the time.
> Now we force the use of hwirq, the driver needs to convert that into a
> virq before requesting the resource. So we need to put *_get_virq()'s into
> every child device that requests an IRQ.
Yes, that's exactly what I said - and as a result of doing this the
remapping in the MFD core becomes redundant.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists