linux-kernel - Re: [PATCH 1/2] perf tools: Initial bash completion support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 07 Aug 2012 20:23:26 -0600
From:	David Ahern <dsahern@...il.com>
To:	Namhyung Kim <namhyung@...nel.org>
CC:	Frederic Weisbecker <fweisbec@...il.com>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	LKML <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>, Jiri Olsa <jolsa@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 1/2] perf tools: Initial bash completion support

On 8/7/12 7:10 PM, Namhyung Kim wrote:
> On Tue, 07 Aug 2012 16:10:54 -0600, David Ahern wrote:
>> On 8/7/12 11:00 AM, Frederic Weisbecker wrote:
>>> diff --git a/tools/perf/Makefile b/tools/perf/Makefile
>>> index 35655c3..ddfb7e5 100644
>>> --- a/tools/perf/Makefile
>>> +++ b/tools/perf/Makefile
>>> @@ -951,6 +951,7 @@ install: all
>>>    	$(INSTALL) scripts/python/Perf-Trace-Util/lib/Perf/Trace/* -t '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/scripts/python/Perf-Trace-Util/lib/Perf/Trace'
>>>    	$(INSTALL) scripts/python/*.py -t '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/scripts/python'
>>>    	$(INSTALL) scripts/python/bin/* -t '$(DESTDIR_SQ)$(perfexec_instdir_SQ)/scripts/python/bin'
>>> +	$(INSTALL) -m 755 bash_completion $(DESTDIR_SQ)/etc/bash_completion.d/perf
>>
>> still getting an error here:
>>
>> $ make DESTDIR=/tmp/junk-perf O=/tmp/pbuild -C tools/perf/ install
>> ...
>> install -m 755 bash_completion /tmp/junk-perf/etc/bash_completion.d/perf
>> install: cannot create regular file
>> /tmp/junk-perf/etc/bash_completion.d/perf': No such file or directory
>> make: *** [install] Error 1
>> make: Leaving directory `/opt/sw/ahern/perf.git/tools/perf'
>
> Does patch below fix it?

Of course. I was too lazy to do that; one liner for Frederic to add - 
though the sysconfdir integration is nice.

David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/