[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Wed, 8 Aug 2012 16:28:04 -0700
From: Tejun Heo <tj@...nel.org>
To: Mikulas Patocka <mpatocka@...hat.com>
Cc: device-mapper development <dm-devel@...hat.com>,
linux-bcache@...r.kernel.org, linux-kernel@...r.kernel.org,
axboe@...nel.dk, Kent Overstreet <koverstreet@...gle.com>,
vgoyal@...hat.com, yehuda@...newdream.net, sage@...dream.net,
agk@...hat.com, drbd-dev@...ts.linbit.com
Subject: Re: [dm-devel] [PATCH v5 12/12] block: Only clone bio vecs that
are in use
On Mon, Aug 06, 2012 at 07:16:33PM -0400, Mikulas Patocka wrote:
> Hi Kent
>
> When you change the semantics of an exported function, rename that
> function. There may be external modules that use __bio_clone and this
> change could silently introduce bugs in them.
>
> Otherwise, the patchset looks fine.
I don't know. This doesn't change the main functionality and should
be transparent unless the caller is doing something crazy. It *might*
be nice to rename but I don't think that's a must here.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists