linux-kernel - Re: [PATCH 01/16] perf symbol: correct comment wrt kallsyms loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 11 Aug 2012 22:14:33 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Cody P Schafer <cody@...ux.vnet.ibm.com>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	LKML <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...hat.com>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>,
	Matt Hellsley <matthltc@...ibm.com>,
	David Hansen <dave@...ux.vnet.ibm.com>
Subject: Re: [PATCH 01/16] perf symbol: correct comment wrt kallsyms loading

2012-08-10 (금), 15:22 -0700, Cody P Schafer:
> In kallsyms_parse() when calling process_symbol() (a callback argument
> to kallsyms_parse()), we pass start as both start & end (ie:
> start=start, end=start).
> 
> In map__process_kallsym_symbol(), the length is calculated as 'end - start + 1',
> making the length 1, not 0.
> 
> Essentially, start & end define an inclusive range.
> 

This seems not needed any more due to the patch #2, right?

Thanks,
Namhyung


> Signed-off-by: Cody P Schafer <cody@...ux.vnet.ibm.com>
> ---
>  tools/perf/util/symbol.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
> index f02de8a..891f83c 100644
> --- a/tools/perf/util/symbol.c
> +++ b/tools/perf/util/symbol.c
> @@ -605,7 +605,7 @@ int kallsyms__parse(const char *filename, void *arg,
>  
>  		/*
>  		 * module symbols are not sorted so we add all
> -		 * symbols with zero length and rely on
> +		 * symbols, setting length to 1, and rely on
>  		 * symbols__fixup_end() to fix it up.
>  		 */
>  		err = process_symbol(arg, symbol_name,



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/