lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 14 Aug 2012 03:31:28 +0100 From: Al Viro <viro@...IV.linux.org.uk> To: John Fastabend <john.r.fastabend@...el.com> Cc: nhorman@...driver.com, netdev@...r.kernel.org, davem@...emloft.net, linux-kernel@...r.kernel.org, joe@...ches.com Subject: Re: [net PATCH v1 2/2] net: netprio: fd passed in SCM_RIGHTS datagram not set correctly On Mon, Aug 13, 2012 at 06:39:45PM -0700, John Fastabend wrote: > /* Bump the usage count and install the file. */ > get_file(fp[i]); > fd_install(new_fd, fp[i]); > + sock = sock_from_file(fp[i], &err); > + if (sock) > + sock->sk->sk_cgrp_prioidx = prioidx; Better to do that before fd_install() exposes the sucker; it's not a serious issue, but it's more obviously correct that way. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists