linux-kernel - RE: [PATCH V2 18/18] Tools: hv: Properly manage open streams

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Aug 2012 03:17:28 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	Ben Hutchings <ben@...adent.org.uk>
CC:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"virtualization@...ts.osdl.org" <virtualization@...ts.osdl.org>,
	"olaf@...fle.de" <olaf@...fle.de>,
	"apw@...onical.com" <apw@...onical.com>
Subject: RE: [PATCH V2 18/18] Tools: hv: Properly manage open streams



> -----Original Message-----
> From: Ben Hutchings [mailto:ben@...adent.org.uk]
> Sent: Monday, August 13, 2012 9:58 PM
> To: KY Srinivasan
> Cc: gregkh@...uxfoundation.org; linux-kernel@...r.kernel.org;
> devel@...uxdriverproject.org; virtualization@...ts.osdl.org; olaf@...fle.de;
> apw@...onical.com
> Subject: Re: [PATCH V2 18/18] Tools: hv: Properly manage open streams
> 
> On Mon, 2012-08-13 at 10:07 -0700, K. Y. Srinivasan wrote:
> > Close the open streams properly.
> >
> > Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> > Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>
> > Reviewed-by: Olaf Hering <olaf@...fle.de>
> > Reviewed-by: Ben Hutchings <ben@...adent.org.uk>
> 
> This isn't reviewed by me, I'm the author!

I am truly sorry for this confusion. I was cleaning up the code based on the
last set of comments I got from Olaf and I did not realize that you had authored
this very patch! Perhaps we can drop this patch from this set.

Regards,

K. Y


> 
> Ben.
> 
> > ---
> >  tools/hv/hv_kvp_daemon.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
> > index c8e1013..ca6424f 100644
> > --- a/tools/hv/hv_kvp_daemon.c
> > +++ b/tools/hv/hv_kvp_daemon.c
> > @@ -160,7 +160,7 @@ static void kvp_update_file(int pool)
> >  				sizeof(struct kvp_record),
> >  				kvp_file_info[pool].num_records, filep);
> >
> > -	fflush(filep);
> > +	fclose(filep);
> >  	kvp_release_lock(pool);
> >  }
> >
> > @@ -206,7 +206,7 @@ static void kvp_update_mem_state(int pool)
> >  	kvp_file_info[pool].num_blocks = num_blocks;
> >  	kvp_file_info[pool].records = record;
> >  	kvp_file_info[pool].num_records = records_read;
> > -
> > +	fclose(filep);
> >  	kvp_release_lock(pool);
> >  }
> >  static int kvp_file_init(void)
> 
> --
> Ben Hutchings
> I say we take off; nuke the site from orbit.  It's the only way to be sure.