lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 15 Aug 2012 08:41:17 +0200 From: Hans de Goede <hdegoede@...hat.com> To: Miklos Szeredi <miklos@...redi.hu> CC: "Rafael J. Wysocki" <rjw@...k.pl>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Tejun Heo <tj@...nel.org>, linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org Subject: Re: [REGRESION] Suspend hangs with 3.6-rc1 on Lenovo T60 notebook Hi, On 08/15/2012 07:13 AM, Miklos Szeredi wrote: > Suspend oopses in generic_ide_suspend() because dev_get_drvdata() > returns NULL (dev->p->driver_data == NULL) and this function is not > prepared for this. > > I bisected it to 0998d063 (device-core: Ensure drvdata = NULL when no > driver is bound). Reverting it fixes suspend. > First of all, thanks for reporting and bisecting this. With that said, I must say that this is very weird. The patch in question: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=0998d063 Only makes dev-drvdata NULL in 2 cases: 1) The probe method of the driver fails 2) The driver has been detached from the device by calling one of: device_release_driver() or driver_detach() Note that in both code paths dev->driver also gets set to NULL, and other generic ide driver callbacks very much depend on that not being NULL, ie: static int generic_ide_remove(struct device *dev) { ide_drive_t *drive = to_ide_device(dev); struct ide_driver *drv = to_ide_driver(dev->driver); if (drv->remove) drv->remove(drive); return 0; } Also how can a drivers suspend callback get called if dev->driver is NULL, since that callback would normally be "reached" through dev->driver, so something weird is going on here ... I hope one of the ide guys can shed some light on this. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists