linux-kernel - Re: [PATCH REBASE 1/2] i2c: tegra: I2_M_NOSTART functionality not supported in Tegra20

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 18 Aug 2012 20:29:40 +0200
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Laxman Dewangan <ldewangan@...dia.com>
Cc:	"khali@...ux-fr.org" <khali@...ux-fr.org>,
	Stephen Warren <swarren@...dia.com>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"olof@...om.net" <olof@...om.net>
Subject: Re: [PATCH REBASE 1/2] i2c: tegra: I2_M_NOSTART functionality not
 supported in Tegra20


> >>-	clk_prepare_enable(i2c_dev->div_clk);
> >>+	/* Support I2C_M_NOSTART only if HW support continue xfer. */
> >>+	for (i = 0; i<  num - 1; i++) {
> >>+		if ((msgs[i + 1].flags&  I2C_M_NOSTART)&&
> >>+			!i2c_dev->has_continue_xfer_support) {
> >>+			dev_err(i2c_dev->dev,
> >>+				"mesg %d have illegal flag\n", i + 1);
> >>+			return -EINVAL;
> >>+		}
> >>+	}
> >Drivers are requested to explicitly check for features of the I2C bus
> >(like M_NOSTART) before using them, so I'd skip this extra check.
> >
> 
> Ok, I kept this as part of flag checking so illegal flag should not
> be passed. I will remove this on next version patch.
> 
> >>+
> >>+	clk_prepare_enable(i2c_dev->clk);
> > From a glimpse, this change looks unrelated at least. Even wrong, no?
> >
> 
> It was already there, just before above check. Due to insertion of
> check, this code shifted, otherwise it is not a new code.

It used to be ->div_clk and now it is ->clk?

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)