linux-kernel - RE: [PATCH] leds-lm3530: replace pwm platform functions with generic pwm functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 20 Aug 2012 07:26:29 +0000
From:	"Kim, Milo" <Milo.Kim@...com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	Bryan Wu <bryan.wu@...onical.com>,
	"thierry.reding@...onic-design.de" <thierry.reding@...onic-design.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] leds-lm3530: replace pwm platform functions with
 generic pwm functions

> In that case, I would recommend changing it from
> 
> +       /* if the pwm device exists, skip requesting the device */
> +       if (drvdata->pwm)
> +               return 0;
> 
> to
> 
> 	/* warn if the PWM was not released prior to reneabling it */
> 	WARN_ON(drvdata->pwm);
> 

OK, thanks for your comments!

Best Regards,
Milo



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/