lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 22 Aug 2012 22:57:00 -0700 (PDT) From: David Miller <davem@...emloft.net> To: cjren@....qualcomm.com Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, qca-linux-team@...lcomm.com, nic-devel@...lcomm.com, xiong@....qualcomm.com, rodrigue@....qualcomm.com Subject: Re: [PATCH v2] net: add new QCA alx ethernet driver From: <cjren@....qualcomm.com> Date: Tue, 21 Aug 2012 00:42:29 +0800 > +config ALX_DEBUGFS > + bool "Qualcomm Atheros debugging interface" > + depends on ALX && DEBUG_FS > + ---help--- > + This option adds ability to debug and test L1F. It can > + support Qualcomm Atheros tools, including diagnostic, memcfg > + and SWOI. Sorry, no vendor specific interfaces, you have to remove this. Anything diagnostic you think is special and unique to your piece of hardware, is almost certainly not, and therefore needs to exist as a generic ethtool or similar interface that other drivers can plug into, not just your's. Driver specific interfaces suck for several reasons, not least of which is the fact that it leads to a terrible user experience. The same task must be done in different ways depending upon what piece of networking hardware and device driver are being used, which the user should never need to know. This is why we require that portable, sane, interfaces are added to ethtool for driver diagnostics. That way users can perform a task in the same way regardless of what hardware and driver are underneath. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists