lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 31 Aug 2012 17:02:43 -0700 From: Josh Triplett <josh@...htriplett.org> To: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com> Cc: linux-kernel@...r.kernel.org, mingo@...e.hu, laijs@...fujitsu.com, dipankar@...ibm.com, akpm@...ux-foundation.org, mathieu.desnoyers@...ymtl.ca, niv@...ibm.com, tglx@...utronix.de, peterz@...radead.org, rostedt@...dmis.org, Valdis.Kletnieks@...edu, dhowells@...hat.com, eric.dumazet@...il.com, darren@...art.com, fweisbec@...il.com, sbw@....edu, patches@...aro.org, m68k <linux-m68k@...ts.linux-m68k.org>, "3.2.x.." <stable@...r.kernel.org> Subject: Re: [PATCH tip/core/rcu 21/26] m68k: Add missing RCU idle APIs on idle loop On Thu, Aug 30, 2012 at 02:05:38PM -0700, Paul E. McKenney wrote: > From: Frederic Weisbecker <fweisbec@...il.com> > > In the old times, the whole idle task was considered > as an RCU quiescent state. But as RCU became more and > more successful overtime, some RCU read side critical > section have been added even in the code of some > architectures idle tasks, for tracing for example. > > So nowadays, rcu_idle_enter() and rcu_idle_exit() must > be called by the architecture to tell RCU about the part > in the idle loop that doesn't make use of rcu read side > critical sections, typically the part that puts the CPU > in low power mode. > > This is necessary for RCU to find the quiescent states in > idle in order to complete grace periods. > > Add this missing pair of calls in the m68k's idle loop. > > Reported-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com> > Signed-off-by: Frederic Weisbecker <fweisbec@...il.com> > Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org> > Cc: m68k <linux-m68k@...ts.linux-m68k.org> > Cc: 3.2.x.. <stable@...r.kernel.org> > Cc: Paul E. McKenney <paulmck@...ux.vnet.ibm.com> Reviewed-by: Josh Triplett <josh@...htriplett.org> > arch/m68k/kernel/process.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/arch/m68k/kernel/process.c b/arch/m68k/kernel/process.c > index c488e3c..ac2892e 100644 > --- a/arch/m68k/kernel/process.c > +++ b/arch/m68k/kernel/process.c > @@ -25,6 +25,7 @@ > #include <linux/reboot.h> > #include <linux/init_task.h> > #include <linux/mqueue.h> > +#include <linux/rcupdate.h> > > #include <asm/uaccess.h> > #include <asm/traps.h> > @@ -75,8 +76,10 @@ void cpu_idle(void) > { > /* endless idle loop with no priority at all */ > while (1) { > + rcu_idle_enter(); > while (!need_resched()) > idle(); > + rcu_idle_exit(); > schedule_preempt_disabled(); > } > } > -- > 1.7.8 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists