lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 3 Sep 2012 15:08:38 +0900 From: Namjae Jeon <linkinjeon@...il.com> To: Al Viro <viro@...iv.linux.org.uk> Cc: hirofumi@...l.parknet.co.jp, akpm@...ux-foundation.org, linux-kernel@...r.kernel.org, Amit Sahrawat <amit.sahrawat83@...il.com> Subject: Re: [PATCH] fat: remove redundent call to fat_detach in vfat_unlink 2012/9/1, Al Viro <viro@...iv.linux.org.uk>: > On Fri, Aug 31, 2012 at 12:48:07PM -0400, Namjae Jeon wrote: >> As after file is removed fat_evict_inode will be called and fat_detach >> will be called from that place. So, fat_detach can be removed from >> vfat_unlink > > NAK. Please, realize that unlink and destruction of file are separate > operations. ->evict_inode() may be called long after ->unlink(); moreover, > during that time you might have another file created, getting the > same directory entry our file used to have. > > This is Unix, damnit. You *can* open file, then unlink it and that file > will keep existing (i.e. you can write to that descriptor, read, etc.) > until it's closed. > Hi Al. Sorry for noise. I understand what you said. There was some confusing to me while checking fat's estale issue.:) I will re-post patch-set about fat estale issue soon.(fix side-effect informed by you and ogawa) I am grateful that you review these patches also if you have time. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists