linux-kernel - Re: [PATCH tip/core/rcu 15/15] kmemleak: Replace list_for_each_continue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 4 Sep 2012 16:41:13 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Josh Triplett <josh@...htriplett.org>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, laijs@...fujitsu.com,
	dipankar@...ibm.com, akpm@...ux-foundation.org,
	mathieu.desnoyers@...ymtl.ca, niv@...ibm.com, tglx@...utronix.de,
	peterz@...radead.org, rostedt@...dmis.org, Valdis.Kletnieks@...edu,
	dhowells@...hat.com, eric.dumazet@...il.com, darren@...art.com,
	fweisbec@...il.com, sbw@....edu, patches@...aro.org,
	Michael Wang <wangyun@...ux.vnet.ibm.com>
Subject: Re: [PATCH tip/core/rcu 15/15] kmemleak: Replace
 list_for_each_continue_rcu with new interface

On Fri, Aug 31, 2012 at 11:55:16AM -0700, Josh Triplett wrote:
> On Thu, Aug 30, 2012 at 11:56:28AM -0700, Paul E. McKenney wrote:
> > From: Michael Wang <wangyun@...ux.vnet.ibm.com>
> > 
> > This patch replaces list_for_each_continue_rcu() with
> > list_for_each_entry_continue_rcu() to save a few lines
> > of code and allow removing list_for_each_continue_rcu().
> > 
> > Signed-off-by: Michael Wang <wangyun@...ux.vnet.ibm.com>
> > Acked-by: Catalin Marinas <catalin.marinas@....com>
> > Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> 
> Reviewed-by: Josh Triplett <josh@...htriplett.org>

And thank you for all the reviews and comments!!!

							Thanx, Paul

> > ---
> >  mm/kmemleak.c |    6 ++----
> >  1 files changed, 2 insertions(+), 4 deletions(-)
> > 
> > diff --git a/mm/kmemleak.c b/mm/kmemleak.c
> > index 45eb621..0de83b4 100644
> > --- a/mm/kmemleak.c
> > +++ b/mm/kmemleak.c
> > @@ -1483,13 +1483,11 @@ static void *kmemleak_seq_next(struct seq_file *seq, void *v, loff_t *pos)
> >  {
> >  	struct kmemleak_object *prev_obj = v;
> >  	struct kmemleak_object *next_obj = NULL;
> > -	struct list_head *n = &prev_obj->object_list;
> > +	struct kmemleak_object *obj = prev_obj;
> >  
> >  	++(*pos);
> >  
> > -	list_for_each_continue_rcu(n, &object_list) {
> > -		struct kmemleak_object *obj =
> > -			list_entry(n, struct kmemleak_object, object_list);
> > +	list_for_each_entry_continue_rcu(obj, &object_list, object_list) {
> >  		if (get_object(obj)) {
> >  			next_obj = obj;
> >  			break;
> > -- 
> > 1.7.8
> > 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/