linux-kernel - Re: [Drbd-dev] [PATCH] drbd: use list_move_tail instead of list_del/list_add_tail

Open Source and information security mailing list archives

Date:	Wed, 05 Sep 2012 14:38:23 +0200
From:	Philipp Reisner <philipp.reisner@...bit.com>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	drbd-dev@...ts.linbit.com, yongjun_wei@...ndmicro.com.cn,
	linux-kernel@...r.kernel.org, drbd-user@...ts.linbit.com
Subject: Re: [Drbd-dev] [PATCH] drbd: use list_move_tail instead of list_del/list_add_tail

Thanks, applied.

Best regards,
 Phil
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> Using list_move_tail() instead of list_del() + list_add_tail().
> 
> spatch with a semantic match is used to found this problem.
> (http://coccinelle.lip6.fr/)
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  drivers/block/drbd/drbd_worker.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/block/drbd/drbd_worker.c
> b/drivers/block/drbd/drbd_worker.c index 6bce2cc..a196281 100644
> --- a/drivers/block/drbd/drbd_worker.c
> +++ b/drivers/block/drbd/drbd_worker.c
> @@ -141,8 +141,7 @@ static void drbd_endio_write_sec_final(struct
> drbd_epoch_entry *e) __releases(lo
> 
>  	spin_lock_irqsave(&mdev->req_lock, flags);
>  	mdev->writ_cnt += e->size >> 9;
> -	list_del(&e->w.list); /* has been on active_ee or sync_ee */
> -	list_add_tail(&e->w.list, &mdev->done_ee);
> +	list_move_tail(&e->w.list, &mdev->done_ee);
> 
>  	/* No hlist_del_init(&e->collision) here, we did not send the Ack yet,
>  	 * neither did we wake possibly waiting conflicting requests.
> 
> 
> _______________________________________________
> drbd-dev mailing list
> drbd-dev@...ts.linbit.com
> http://lists.linbit.com/mailman/listinfo/drbd-dev
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives