linux-kernel - [PATCH] x86: fix range check in tlbflush debugfs interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 07 Sep 2012 07:54:52 +0100
From:	"Jan Beulich" <JBeulich@...e.com>
To:	<mingo@...e.hu>, <tglx@...utronix.de>, <hpa@...or.com>
Cc:	"Alex Shi" <alex.shi@...el.com>, <linux-kernel@...r.kernel.org>
Subject: [PATCH] x86: fix range check in tlbflush debugfs interface

Since the shift count settable there is used for shifting values of
type "unsigned long", its value must not match or exceed BITS_PER_LONG
(otherwise the shift operations are undefined). Similarly, the value
must not be negative (but -1 must be permitted, as that's the value
used to distinguish the case of the fine grained flushing being
disabled).

Signed-off-by: Jan Beulich <jbeulich@...e.com>
Cc: Alex Shi <alex.shi@...el.com>

---
 arch/x86/mm/tlb.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- 3.6-rc4/arch/x86/mm/tlb.c
+++ 3.6-rc4-x86-tlb_flushall_shift-limits/arch/x86/mm/tlb.c
@@ -320,7 +320,7 @@ static ssize_t tlbflush_write_file(struc
 	if (kstrtos8(buf, 0, &shift))
 		return -EINVAL;
 
-	if (shift > 64)
+	if (shift < -1 || shift >= BITS_PER_LONG)
 		return -EINVAL;
 
 	tlb_flushall_shift = shift;



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/