linux-kernel - Re: [PATCH] perf, ibs: Check syscall attribute flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 7 Sep 2012 19:07:00 +0200
From:	Robert Richter <robert.richter@....com>
To:	David Ahern <dsahern@...il.com>
CC:	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...nel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf, ibs: Check syscall attribute flags

On 07.09.12 10:50:35, David Ahern wrote:
> On 9/7/12 10:41 AM, Robert Richter wrote:
> > +	struct perf_event_attr notsupp = {
> > +		.exclude_user	= 1,
> > +		.exclude_kernel	= 1,
> > +		.exclude_hv	= 1,
> > +		.exclude_idle	= 1,
> > +		.exclude_host	= 1,
> > +		.exclude_guest	= 1,
> > +	};
> >
> >   	perf_ibs = get_ibs_pmu(event->attr.type);
> >   	if (perf_ibs) {
> > @@ -229,6 +237,9 @@ static int perf_ibs_init(struct perf_event *event)
> >   	if (event->pmu != &perf_ibs->pmu)
> >   		return -ENOENT;
> >
> > +	if (perf_flags(&event->attr) & perf_flags(&notsupp))
> > +		return -EINVAL;
> > +
> 
> Am I reading this right - if exclude_guest is set then perf_ibs_init 
> returns -EINVAL?

Yes, the hardware does not support this. I will look for a solution
which emulates this is software.

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/