linux-kernel - Re: [PATCH 06/11] target: go through normal processing for zero-length REQUEST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 07 Sep 2012 11:33:29 -0700
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	Paolo Bonzini <pbonzini@...hat.com>
Cc:	linux-kernel@...r.kernel.org, target-devel@...r.kernel.org,
	hch@....de, roland@...nel.org
Subject: Re: [PATCH 06/11] target: go through normal processing for
 zero-length REQUEST_SENSE

On Fri, 2012-09-07 at 11:23 -0700, Nicholas A. Bellinger wrote:
> On Fri, 2012-09-07 at 17:30 +0200, Paolo Bonzini wrote:
> > Now that spc_emulate_request_sense has been taught to process zero-length
> > REQUEST SENSE correctly, drop the special handling of unit attention
> > conditions from transport_generic_new_cmd.  However, for now REQUEST SENSE
> > will be the only command that goes through emulation for zero lengths.
> > 
> > Signed-off-by: Paolo Bonzini <pbonzini@...hat.com>
> > ---

<SNIP>

> >  drivers/target/target_core_transport.c |    8 +-------
> >  1 files changed, 1 insertions(+), 7 deletions(-)
> > 
> > diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
> > index 8facb74..09d9279 100644
> > --- a/drivers/target/target_core_transport.c
> > +++ b/drivers/target/target_core_transport.c
> > @@ -2301,6 +2301,7 @@ int transport_generic_new_cmd(struct se_cmd *cmd)
> >  	 * away.
> >  	 */
> >  	if (!cmd->data_length &&
> > +	    cmd->t_task_cdb[0] != REQUEST_SENSE &&
> >  	    (cmd->se_dev->transport->transport_type != TRANSPORT_PLUGIN_PHBA_PDEV ||
> >  	     cmd->t_task_cdb[0] == REPORT_LUNS) {
> >  		spin_lock_irq(&cmd->t_state_lock);

Btw, this section does not compile.

I'm squashing the following into your original patch.  Let me know if
you have any objections.

Thanks Paolo!

diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index cda32eb..269f544 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -2307,8 +2307,7 @@ int transport_generic_new_cmd(struct se_cmd *cmd)
         */
        if (!cmd->data_length &&
            cmd->t_task_cdb[0] != REQUEST_SENSE &&
-           (cmd->se_dev->transport->transport_type != TRANSPORT_PLUGIN_PHBA_PDEV ||
-            cmd->t_task_cdb[0] == REPORT_LUNS) {
+           cmd->se_dev->transport->transport_type != TRANSPORT_PLUGIN_PHBA_PDEV) {
                spin_lock_irq(&cmd->t_state_lock);
                cmd->t_state = TRANSPORT_COMPLETE;
                cmd->transport_state |= CMD_T_ACTIVE;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/