linux-kernel - Re: [PATCH v2] Add missing attributes to EFI variable attribute print out from sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 10 Sep 2012 12:58:43 -0600
From:	Khalid Aziz <khalid.aziz@...com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Mike Waychison <mikew@...gle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Tony Luck <tony.luck@...el.com>,
	Matthew Garrett <mjg@...hat.com>,
	Kees Cook <keescook@...omium.org>,
	"gong.chen@...ux.intel.com" <gong.chen@...ux.intel.com>,
	khalid@...ehiking.org
Subject: Re: [PATCH v2] Add missing attributes to EFI variable attribute
 print out from sysfs

On Mon, 2012-09-10 at 11:35 -0700, Greg KH wrote:
> On Mon, Sep 10, 2012 at 12:29:14PM -0600, Khalid Aziz wrote:
> > Some of the EFI variable attributes are missing from print out from
> > /sys/firmware/efi/vars/*/attributes. This patch adds those in. It also
> > updates code to use pre-defined constants for masking current value
> > of attributes.
> > 
> > Signed-off-by: Khalid Aziz <khalid.aziz@...com>
> > Reviewed-by: Kees Cook <keescook@...omium.org>
> > Acked-by: Matthew Garrett <mjg@...hat.com>
> > Cc: stable@...r.kernel.org
> > ---
> >  drivers/firmware/efivars.c |   17 ++++++++++++++---
> >  1 file changed, 14 insertions(+), 3 deletions(-)
> > diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c
> > index 47408e8..d10c987 100644
> 
> Ah, so close...
> 
> What's with the "Re:" in the Subject"?
> 
> And what happened to the extra line that should be after the diffstat
> and before the "diff --" line?
> 
> Third time's a charm?

Sorry, Greg. I screwed up. I need to pay closer attention. Hopefully the
one I just sent out does the job.

-- 
Khalid Aziz <khalid.aziz@...com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/