linux-kernel - Re: linux-next: build warning after merge of the final tree (slab tree related)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Sep 2012 19:49:38 +0000
From:	Christoph Lameter <cl@...ux.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
cc:	Pekka Enberg <penberg@...helsinki.fi>, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: linux-next: build warning after merge of the final tree (slab
 tree related)

On Tue, 11 Sep 2012, Stephen Rothwell wrote:

> After merging the final tree, today's linux-next build (sparc64 defconfig)
> produced this warning:
>
> mm/slab.c:808:13: warning: '__slab_error' defined but not used [-Wunused-function]
>
> Introduced by commit 945cf2b6199b ("mm/sl[aou]b: Extract a common function for kmem_cache_destroy").  All uses of slab_error() are now guarded by DEBUG.


Subject: Slab: Only define slab_error for DEBUG

There is no use case left for slab builds without DEBUG.

Signed-off-by: Christoph Lameter <cl@...ux.com>

Index: linux/mm/slab.c
===================================================================
--- linux.orig/mm/slab.c	2012-09-11 14:44:56.304015235 -0500
+++ linux/mm/slab.c	2012-09-11 14:48:46.988948440 -0500
@@ -803,6 +803,7 @@ static void cache_estimate(unsigned long
 	*left_over = slab_size - nr_objs*buffer_size - mgmt_size;
 }

+#if DEBUG
 #define slab_error(cachep, msg) __slab_error(__func__, cachep, msg)

 static void __slab_error(const char *function, struct kmem_cache *cachep,
@@ -812,6 +813,7 @@ static void __slab_error(const char *fun
 	       function, cachep->name, msg);
 	dump_stack();
 }
+#endif

 /*
  * By default on NUMA we use alien caches to stage the freeing of
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/