linux-kernel - Re: [PATCH 2/3] scsi: create an all-zero filter for scanners

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 12 Sep 2012 14:32:49 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	linux-kernel@...r.kernel.org, Tejun Heo <tj@...nel.org>,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	Jens Axboe <axboe@...nel.dk>,
	Ric Wheeler <rwheeler@...hat.com>, linux-iscsi@...r.kernel.org
Subject: Re: [PATCH 2/3] scsi: create an all-zero filter for scanners

Il 12/09/2012 14:36, Alan Cox ha scritto:
>> >  	switch (sdev->type) {
>> > +	case TYPE_SCANNER:
>> > +		sdev->request_queue->cmd_filter =
>> > +			kzalloc(sizeof(struct blk_cmd_filter), GFP_KERNEL);
>> > +		/* fallthrough */
> Is that really desireable in the kzalloc failing case ?

Hmm, there is another kmalloc failure in the series that is worse than
this one, actually.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/