linux-kernel - RE: [PATCH 09/16] ARM: tegra: move platform_data definitions

Open Source and information security mailing list archives

Date:	Wed, 12 Sep 2012 16:42:31 +0000
From:	"Chris Brand" <chris.brand@...adcom.com>
To:	"Arnd Bergmann" <arnd@...db.de>, "Chris Ball" <cjb@...top.org>
cc:	"Mark Brown" <broonie@...nsource.wolfsonmicro.com>,
	"Russell King" <linux@....linux.org.uk>,
	"Stephen Warren" <swarren@...dotorg.org>,
	"Dmitry Torokhov" <dmitry.torokhov@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"Colin Cross" <ccross@...roid.com>,
	"Olof Johansson" <olof@...om.net>, "Liam Girdwood" <lrg@...com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH 09/16] ARM: tegra: move platform_data definitions

You'll want to check that you don't have any cases where two files use the same guard, I'd think.

Chris

-----Original Message-----
From: linux-arm-kernel-bounces@...ts.infradead.org [mailto:linux-arm-kernel-bounces@...ts.infradead.org] On Behalf Of Arnd Bergmann
Sent: September 11, 2012 10:06 AM
To: Chris Ball
Cc: Mark Brown; Russell King; Stephen Warren; Dmitry Torokhov; linux-kernel@...r.kernel.org; linux-tegra@...r.kernel.org; Colin Cross; Olof Johansson; Liam Girdwood; linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 09/16] ARM: tegra: move platform_data definitions

On Tuesday 11 September 2012, Chris Ball wrote:
> On Tue, Sep 11 2012, Arnd Bergmann wrote:
> > diff --git a/arch/arm/mach-tegra/include/mach/sdhci.h
> > b/include/linux/platform_data/mmc-sdhci-tegra.h
> > similarity index 100%
> > rename from arch/arm/mach-tegra/include/mach/sdhci.h
> > rename to include/linux/platform_data/mmc-sdhci-tegra.h
> 
> Looks like you aren't renaming the idempotency guards, so e.g.
> include/linux/platform_data/mmc-sdhci-tegra.h will contain:
> 
> #ifndef __ASM_ARM_ARCH_TEGRA_SDHCI_H
> #define __ASM_ARM_ARCH_TEGRA_SDHCI_H
> 
> Is that intentional?  Thanks,
> 

No, it's not intentional. We actually have a lot of instances that
are already wrong. Do we care enough to change the ones I'm moving here?

	Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@...ts.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives