linux-kernel - Re: [PATCH 1/2] leds-lp5523: turn off the LED engines on unloading the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 13 Sep 2012 11:49:39 +0800
From:	Bryan Wu <bryan.wu@...onical.com>
To:	"Kim, Milo" <Milo.Kim@...com>
Cc:	"linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Richard Purdie <rpurdie@...ys.net>
Subject: Re: [PATCH 1/2] leds-lp5523: turn off the LED engines on unloading
 the driver

On Wed, Sep 12, 2012 at 8:16 PM, Kim, Milo <Milo.Kim@...com> wrote:
>  The LP5523 has 3 engines which are used for running LED patterns.
>  These engines should be off while unloading the driver.
>  Obviously, LP5523 platform data are used for releasing the resource
>  such like enable()/release_resource(), but these are not mandatory.
>  Therefore this patch is required without the platform data dependency.
>

Thanks, merged into my for-next branch
-Bryan

> Signed-off-by: Milo(Woogyom) Kim <milo.kim@...com>
> ---
>  drivers/leds/leds-lp5523.c |    3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c
> index 3d60428..5ebdc92 100644
> --- a/drivers/leds/leds-lp5523.c
> +++ b/drivers/leds/leds-lp5523.c
> @@ -997,6 +997,9 @@ static int lp5523_remove(struct i2c_client *client)
>         struct lp5523_chip *chip = i2c_get_clientdata(client);
>         int i;
>
> +       /* Disable engine mode */
> +       lp5523_write(client, LP5523_REG_OP_MODE, LP5523_CMD_DISABLED);
> +
>         lp5523_unregister_sysfs(client);
>
>         for (i = 0; i < chip->num_leds; i++) {
> --
> 1.7.9.5
>
>
> Best Regards,
> Milo
>



-- 
Bryan Wu <bryan.wu@...onical.com>
Kernel Developer    +86.186-168-78255 Mobile
Canonical Ltd.      www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/