linux-kernel - Re: [PATCH 1/2] mfd/janz-cmodio: fix MODULBus number sysfs entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 13 Sep 2012 13:56:32 +0200
From:	Marc Kleine-Budde <mkl@...gutronix.de>
To:	"Ira W. Snyder" <iws@...o.caltech.edu>
CC:	linux-kernel@...r.kernel.org, linux-can@...r.kernel.org,
	sameo@...ux.intel.com
Subject: Re: [PATCH 1/2] mfd/janz-cmodio: fix MODULBus number sysfs entry

On 09/12/2012 12:58 AM, Ira W. Snyder wrote:
> From: "Ira W. Snyder" <iws@...o.caltech.edu>
> 
> Revision 1.0 of the Janz CMOD-IO Carrier Board does not contain zeroes
> in the top 4 bits of the modulbus_num (int_enable) register. Mask off
> the unused bits so that the correct value is displayed in sysfs.
> 
> Cc: Samuel Ortiz <sameo@...ux.intel.com>
> Signed-off-by: Ira W. Snyder <iws@...o.caltech.edu>

Who will take care of this patch?

Marc

> ---
>  drivers/mfd/janz-cmodio.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mfd/janz-cmodio.c b/drivers/mfd/janz-cmodio.c
> index 2ea9998..32d0efd 100644
> --- a/drivers/mfd/janz-cmodio.c
> +++ b/drivers/mfd/janz-cmodio.c
> @@ -216,7 +216,7 @@ static int __devinit cmodio_pci_probe(struct pci_dev *dev,
>  	}
>  
>  	/* Read the hex switch on the carrier board */
> -	priv->hex = ioread8(&priv->ctrl->int_enable);
> +	priv->hex = ioread8(&priv->ctrl->int_enable) & 0x0f;
>  
>  	/* Add the MODULbus number (hex switch value) to the device's sysfs */
>  	ret = sysfs_create_group(&dev->dev.kobj, &cmodio_sysfs_attr_group);
> 


-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


Download attachment "signature.asc" of type "application/pgp-signature" (260 bytes)