linux-kernel - Re: [PATCH v2 0/10] mm: SLxB cleaning and trace accuracy improvement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 12 Sep 2012 21:28:47 -0300
From:	Ezequiel Garcia <elezegarcia@...il.com>
To:	Pekka Enberg <penberg@...nel.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Cc:	JoonSoo Kim <js1304@...il.com>, Tim Bird <tim.bird@...sony.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	David Rientjes <rientjes@...gle.com>,
	Christoph Lameter <cl@...ux.com>,
	Glauber Costa <glommer@...allels.com>
Subject: Re: [PATCH v2 0/10] mm: SLxB cleaning and trace accuracy improvement

Hi Pekka,

On Sat, Sep 8, 2012 at 5:49 PM, Ezequiel Garcia <elezegarcia@...il.com> wrote:
> Hi everyone,
>
> This is the second spin of my patchset to clean SLxB and improve kmem
> trace events accuracy.
>
> For this v2, the most relevant stuff is:
>
> I've dropped two patches that were not very well received:
> Namely this two are now gone:
>   mm, slob: Use only 'ret' variable for both slob object and returned pointer
>   mm, slob: Trace allocation failures consistently
> I believe consistency is important but perhaps this is just me being paranoid.
>
> There's a lot of dumb movement and renaming. This might seem stupid
> (and maybe it is) but it's necessary to create some common code between SLAB
> and SLUB, and then factor it out.
>
> Also, there's a patch to add a new option to disable gcc auto-inlining.
> I know we hate to add new options, but this is necessary to get
> accurate call site
> traces. Plus, the option is in "Kernel Hacking", so it's for kernel
> developers only.
>
> This work is part of CELF Workgroup Project:
> "Kernel_dynamic_memory_allocation_tracking_and_reduction" [1]
>
> Feedback, comments, suggestions are very welcome.
>
> Ezequiel Garcia (10):
>  mm: Factor SLAB and SLUB common code
>  mm, slub: Rename slab_alloc() -> slab_alloc_node() to match SLAB
>  mm, slab: Rename __cache_alloc() -> slab_alloc()
>  mm, slab: Match SLAB and SLUB kmem_cache_alloc_xxx_trace() prototype
>  mm, slab: Replace 'caller' type, void* -> unsigned long
>  mm, util: Use dup_user to duplicate user memory
>  mm, slob: Add support for kmalloc_track_caller()
>  mm, slab: Remove silly function slab_buffer_size()
>  mm, slob: Use NUMA_NO_NODE instead of -1
>  Makefile: Add option CONFIG_DISABLE_GCC_AUTOMATIC_INLINING
>

Can you pick patches 2, 3, 4, and 5?
Namely only those related to SLOB and to simple cleanups.

I'll redo SLAB/SLUB commonization, as Christoph requested.

Thanks,
Ezequiel.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/