linux-kernel - Re: [PATCH v2 0/3] Input: cyttsp4 - driver for Cypress TMA4XX touchscreen devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 15 Sep 2012 17:42:01 +0200
From:	Javier Martinez Canillas <javier@...hile0.org>
To:	Ferruh Yigit <fery@...ress.com>
Cc:	Henrik Rydberg <rydberg@...omail.se>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Kevin McNeely <kev@...ress.com>,
	Phil Warkentin <pwar@...ress.com>,
	Shawn Landden <shawnlandden@...il.com>,
	Ashish Jangam <ashish.jangam@...tcummins.com>,
	Olivier Sobrie <olivier@...rie.be>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/3] Input: cyttsp4 - driver for Cypress TMA4XX
 touchscreen devices

On Fri, Sep 14, 2012 at 8:46 PM, Henrik Rydberg <rydberg@...omail.se> wrote:
> Hi Ferruh,
>
>> This driver is for Cypress TrueTouch(tm) Standard Product controllers,
>> Generation4 devices.
>>
>> This is second version of driver, code re-structured to match with
>> existing Generation3 driver code.
>
> To integrate with the existing gen3 driver is clearly not the same as
> creating a parallel set of files, which obviously share a lot of code
> with the gen3 code.
>
> For instance, the i2c transfer layer seems more or less identical to
> the existing one; just look at cyttsp_i2c_write_block_data() versus
> cyttsp4_i2c_write_block_data(). If different generations of device
> data cannot even be transported through the same _generic_ interface,
> something is clearly not right.
>
> You can't seriously expect anyone to want to maintain one set of files
> for every new version. Please make sure to build on what is already
> there.
>
> Thanks.
> Henrik
> --

Hi Ferruh,

Thanks a lot for taking the time to try to modify your driver to fit
wit the existent Gen3 driver but I agree with Henrik that it seems
that at least the transport code from the Gen3 driver could be reused.

As he said the i2c layer code is almost identical and even when there
are some differences on the spi transfer functions I think that the
current Gen3 spi transport code could be refactor to support it. These
differences seems to be only minor as far as I understood by looking
at cyttsp_spi_xfer() and cyttsp4_spi_xfer() functions.

Also it seems that you forgot to post your 1/3 patch from your series
that adds the Gen4 core driver. At least I couldn't find neither on my
mailbox nor on linux-input archives the patch:

[PATCH v2 1/3] Input: cyttsp4 - core driver for Cypress TMA4XX
touchscreen devices

So I couldn't take a look to try to figure out if the current Gen3
core driver can be extended to support the new Gen4 family or if new
core driver file is actually needed.

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/