linux-kernel - Re: [PATCH] ARM: OMAP: OMAP_DEBUG_LEDS needs to select LEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 18 Sep 2012 14:34:48 +0800
From:	Bryan Wu <bryan.wu@...onical.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	Tony Lindgren <tony@...mide.com>, linux-omap@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: OMAP: OMAP_DEBUG_LEDS needs to select LEDS_CLASS

On Tue, Sep 18, 2012 at 11:30 AM, Axel Lin <axel.lin@...il.com> wrote:
> This fixes below build error when CONFIG_LEDS_CLASS is not set.
>
>   LD      init/built-in.o
> arch/arm/plat-omap/built-in.o: In function `fpga_probe':
> arch/arm/plat-omap/debug-leds.c:113: undefined reference to `led_classdev_register'
> make: *** [vmlinux] Error 1
>

Thanks for posting this. But I think Tony has already fixed it in mainline:
--
commit 359f64f7b3997e94ee71039b5fcdc1278b9b77c4
Author: Tony Lindgren <tony@...mide.com>
Date:   Wed Sep 15 10:18:51 2010 -0700

    omap: Fix compile dependency to LEDS_CLASS

    If we LEDS_CLASS is not selected, we will get undefined reference
    to `led_classdev_register'.

    Signed-off-by: Tony Lindgren <tony@...mide.com>
--

-Bryan

> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  arch/arm/plat-omap/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig
> index ca83a76..c262781 100644
> --- a/arch/arm/plat-omap/Kconfig
> +++ b/arch/arm/plat-omap/Kconfig
> @@ -43,6 +43,7 @@ config OMAP_DEBUG_DEVICES
>
>  config OMAP_DEBUG_LEDS
>         def_bool y if NEW_LEDS
> +       select LEDS_CLASS
>         depends on OMAP_DEBUG_DEVICES
>
>  config POWER_AVS_OMAP
> --
> 1.7.9.5
>
>
>



-- 
Bryan Wu <bryan.wu@...onical.com>
Kernel Developer    +86.186-168-78255 Mobile
Canonical Ltd.      www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/