lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Sep 2012 18:52:07 -0700 From: "Eric W. Biederman" <ebiederm@...ssion.com> To: <linux-kernel@...r.kernel.org> Cc: <linux-fsdevel@...r.kernel.org>, Serge Hallyn <serge@...lyn.com>, Linux Containers <containers@...ts.linux-foundation.org>, linux-security-module@...r.kernel.org, Jan Kara <jack@...e.cz>, Dave Chinner <david@...morbit.com>, Al Viro <viro@...iv.linux.org.uk>, Eric Paris <eparis@...hat.com>, David Miller <davem@...emloft.net>, "Eric W. Biederman" <ebiederm@...ssion.com> Subject: [PATCH 05/27] audit: kill audit_prepare_user_tty From: "Eric W. Biederman" <ebiederm@...ssion.com> Now that netlink messages are processed in the context of the sender tty_audit_push_task can be called directly and audit_prepare_user_tty which only added looking up the task of the tty by process id is not needed. Cc: Al Viro <viro@...iv.linux.org.uk> Cc: Eric Paris <eparis@...hat.com> Signed-off-by: "Eric W. Biederman" <ebiederm@...ssion.com> --- kernel/audit.c | 20 +------------------- 1 files changed, 1 insertions(+), 19 deletions(-) diff --git a/kernel/audit.c b/kernel/audit.c index fecb150..58f704b 100644 --- a/kernel/audit.c +++ b/kernel/audit.c @@ -468,24 +468,6 @@ static int kauditd_thread(void *dummy) return 0; } -static int audit_prepare_user_tty(pid_t pid, uid_t loginuid, u32 sessionid) -{ - struct task_struct *tsk; - int err; - - rcu_read_lock(); - tsk = find_task_by_vpid(pid); - if (!tsk) { - rcu_read_unlock(); - return -ESRCH; - } - get_task_struct(tsk); - rcu_read_unlock(); - err = tty_audit_push_task(tsk, loginuid, sessionid); - put_task_struct(tsk); - return err; -} - int audit_send_list(void *_dest) { struct audit_netlink_list *dest = _dest; @@ -748,7 +730,7 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh) if (err == 1) { err = 0; if (msg_type == AUDIT_USER_TTY) { - err = audit_prepare_user_tty(pid, loginuid, + err = tty_audit_push_task(current, loginuid, sessionid); if (err) break; -- 1.7.5.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists