linux-kernel - Re: [PATCH] ARM: pxa: fix return value check in pxa2xx_drv_pcmcia

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Sep 2012 15:30:33 +0800
From:	Eric Miao <eric.y.miao@...il.com>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	linux@....linux.org.uk, haojian.zhuang@...il.com,
	yongjun_wei@...ndmicro.com.cn,
	linux-arm-kernel@...ts.infradead.org,
	linux-pcmcia@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: pxa: fix return value check in pxa2xx_drv_pcmcia_probe()

On Fri, Sep 21, 2012 at 3:19 PM, Wei Yongjun <weiyj.lk@...il.com> wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
> In case of error, the function clk_get() returns ERR_PTR()
> and never returns NULL pointer. The NULL test in the error
> handling should be replaced with IS_ERR().
>
> dpatch engine is used to auto generated this patch.
> (https://github.com/weiyj/dpatch)
>
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

Ack

> ---
>  drivers/pcmcia/pxa2xx_base.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pcmcia/pxa2xx_base.c b/drivers/pcmcia/pxa2xx_base.c
> index 490bb82..cfec9dd 100644
> --- a/drivers/pcmcia/pxa2xx_base.c
> +++ b/drivers/pcmcia/pxa2xx_base.c
> @@ -297,7 +297,7 @@ static int pxa2xx_drv_pcmcia_probe(struct platform_device *dev)
>         }
>
>         clk = clk_get(&dev->dev, NULL);
> -       if (!clk)
> +       if (IS_ERR(clk))
>                 return -ENODEV;
>
>         pxa2xx_drv_pcmcia_ops(ops);
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/