linux-kernel - Re: [PATCH 2/6] ARM: dove: Fix tauros2 device tree init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Sep 2012 03:22:04 +0200
From:	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
To:	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
CC:	Russell King <linux@....linux.org.uk>,
	Jason Cooper <jason@...edaemon.net>,
	Andrew Lunn <andrew@...n.ch>, Olof Johansson <olof@...om.net>,
	Arnd Bergmann <arnd@...db.de>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] ARM: dove: Fix tauros2 device tree init

On 09/25/2012 02:02 AM, Sebastian Hesselbarth wrote:
> During the review process of dove DT patches, Tauros2 cache
> init call was changed and DT support added. This patch fixes
> the call to Tauros2 init and adds a DT node. Moreover, plat/irq.h
> include was missing from mach-dove/common.c.
 > ...
> diff --git a/arch/arm/mach-dove/common.c b/arch/arm/mach-dove/common.c
> index b37bef1..343a4bc 100644
> --- a/arch/arm/mach-dove/common.c
> +++ b/arch/arm/mach-dove/common.c
> @@ -32,6 +32,7 @@
>   #include<linux/irq.h>
>   #include<plat/time.h>
>   #include<linux/platform_data/usb-ehci-orion.h>
> +#include<plat/irq.h>
>   #include<plat/common.h>
>   #include<plat/addr-map.h>
>   #include "common.h"
> @@ -399,7 +400,7 @@ static void __init dove_dt_init(void)
>   		(dove_tclk + 499999) / 1000000);
>
>   #ifdef CONFIG_CACHE_TAUROS2
> -	tauros2_init();
> +	tauros2_init(0);
>   #endif
>   	dove_setup_cpu_mbus();
>

I thought about the importance of the individual patches and
except 2/6 all can wait for the next release cycle if too late.

But 2/6 is important because the change in tauros2_init
breaks build on dove.

Sebastian

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/