linux-kernel - [PATCH] GPIO: gpio-pxa: fix bug when get gpio value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Sep 2012 20:03:42 +0800
From:	Neil Zhang <zhangwm@...vell.com>
To:	grant.likely@...retlab.ca, linus.walleij@...aro.org,
	haojian.zhuang@...il.com
Cc:	linux-kernel@...r.kernel.org, Neil Zhang <zhangwm@...vell.com>
Subject: [PATCH] GPIO: gpio-pxa: fix bug when get gpio value

We need to return 0 or 1 when get gpio value.

Signed-off-by: Neil Zhang <zhangwm@...vell.com>
---
 drivers/gpio/gpio-pxa.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index 9cac88a..1f9a058 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -269,7 +269,10 @@ static int pxa_gpio_direction_output(struct gpio_chip *chip,
 
 static int pxa_gpio_get(struct gpio_chip *chip, unsigned offset)
 {
-	return readl_relaxed(gpio_chip_base(chip) + GPLR_OFFSET) & (1 << offset);
+	u32 gplr = __raw_readl(gpio_chip_base(chip) + GPLR_OFFSET);
+	u32 mask = 1 << offset;
+
+	return (gplr & mask) != 0;
 }
 
 static void pxa_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
-- 
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/