linux-kernel - Re: [PATCHv3 3/7] dmaengine: dw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 27 Sep 2012 11:17:01 +0300
From:	Felipe Balbi <balbi@...com>
To:	viresh kumar <viresh.kumar@...aro.org>
Cc:	balbi@...com, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Vinod Koul <vinod.koul@...el.com>,
	linux-kernel@...r.kernel.org,
	spear-devel <spear-devel@...t.st.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Subject: Re: [PATCHv3 3/7] dmaengine: dw_dmac: remove CLK dependency

On Thu, Sep 27, 2012 at 01:47:58PM +0530, viresh kumar wrote:
> On Thu, Sep 27, 2012 at 1:12 PM, Felipe Balbi <balbi@...com> wrote:
> > Hi,
> >
> > On Thu, Sep 27, 2012 at 10:31:57AM +0300, Andy Shevchenko wrote:
> >> From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> >>
> >> This driver could be used on different platforms. Thus, the HAVE_CLK dependency
> >> is dropped away.
> >>
> >> Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> >> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> >> ---
> >>  drivers/dma/Kconfig |    1 -
> >>  1 file changed, 1 deletion(-)
> >>
> >> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> >> index 677cd6e..df32537 100644
> >> --- a/drivers/dma/Kconfig
> >> +++ b/drivers/dma/Kconfig
> >> @@ -83,7 +83,6 @@ config INTEL_IOP_ADMA
> >>
> >>  config DW_DMAC
> >>       tristate "Synopsys DesignWare AHB DMA support"
> >> -     depends on HAVE_CLK
> >
> > as is, this will break compilation of any arch which doesn't set
> > HAVE_CLK.
> 
> No, it will not due to following commit id:
> 
> commit 93abe8e4b13ae9a0428ce940a8a03ac72a7626f1
> Author: Viresh Kumar <viresh.kumar@...com>
> Date:   Mon Jul 30 14:39:27 2012 -0700
> 
>     clk: add non CONFIG_HAVE_CLK routines
> 
> 
> @Andy:
> 
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

Reviewed-by: Felipe Balbi <balbi@...com>

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)